Last time, I got the tests for Charging out of the way, and got through a raft of simple checks for Hiding. This time, a few of the more complicated checks.<\/p>\n
First off, a model can move around while hiding as long as it remains out of sight. I\u2019m not sure how to be checking every point along the move, but I can check at the end of the movement whether it\u2019s still out of sight.<\/p>\n
[TestMethod<\/span>]\npublic void <\/span>Hide_ThrowsExceptionIfInSightAfterMove()\n{\nMock<\/span><IGameManager<\/span>> mockGameManager = new <\/span>Mock<\/span><IGameManager<\/span>>();\nMock<\/span><IObjectManager<\/span>> mockObjectManager = new <\/span>Mock<\/span><IObjectManager<\/span>>();\nModel <\/span>enemyModel = new <\/span>Model<\/span>(1, mockGameManager.Object, mockObjectManager.Object);\nmockGameManager.Setup(item => item.Models).Returns(new <\/span>List<\/span><IModel<\/span>>() { enemyModel });\nModel <\/span>testModel = new <\/span>Model<\/span>(2, mockGameManager.Object, mockObjectManager.Object);\ntestModel.Movement = 4;\nbool <\/span>exceptionThrown = false<\/span>;\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(0);\ntestModel.Hide();\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(1);\nAssert<\/span>.IsTrue(testModel.IsHiding);\ntry\n<\/span>{\ntestModel.MoveModel(4, 0, 0);\n}\ncatch <\/span>(HidingException <\/span>ex)\n{\nexceptionThrown = true<\/span>;\nAssert<\/span>.AreEqual(enemyModel, ex.EnemyModels[0]);\n}\nAssert<\/span>.IsTrue(exceptionThrown);\nAssert<\/span>.IsFalse(testModel.IsHiding);\n}<\/pre>\nThe best way to check this is probably to call the Hide method at the end of MoveModel \u2013 any change in the model\u2019s visibility will be picked up. Code re-use: excellent!<\/p>\n
if <\/span>(this<\/span>.IsHiding)\n{\nthis<\/span>.Hide();\n}<\/pre>\nBut I still don\u2019t get a pass… I also need to set IsHiding to false in the Hide method, when it throws an exception. Then the test goes green.<\/p>\n
The next test is that after an enemy model has moved, it might force a model to stop being hidden. I will keep the current action of throwing an exception \u2013 this will let the imaginary UI show that hiding has ceased.<\/p>\n
[TestMethod<\/span>]\npublic void <\/span>Hide_StopsHidingIfInSightAfterEnemyMove()\n{\nMock<\/span><IGameManager<\/span>> mockGameManager = new <\/span>Mock<\/span><IGameManager<\/span>>();\nMock<\/span><IObjectManager<\/span>> mockObjectManager = new <\/span>Mock<\/span><IObjectManager<\/span>>();\nModel <\/span>enemyModel = new <\/span>Model<\/span>(1, mockGameManager.Object, mockObjectManager.Object);\nmockGameManager.Setup(item => item.Models).Returns(new <\/span>List<\/span><IModel<\/span>>() { enemyModel });\nModel <\/span>testModel = new <\/span>Model<\/span>(2, mockGameManager.Object, mockObjectManager.Object);\nenemyModel.Movement = 4;\nbool <\/span>exceptionThrown = false<\/span>;\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(0);\ntestModel.Hide();\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(1);\nAssert<\/span>.IsTrue(testModel.IsHiding);\ntry\n<\/span>{\nenemyModel.MoveModel(4, 0, 0);\n}\ncatch <\/span>(HidingException <\/span>ex)\n{\nexceptionThrown = true<\/span>;\nAssert<\/span>.AreEqual(enemyModel, ex.EnemyModels[0]);\n}\nAssert<\/span>.IsTrue(exceptionThrown);\nAssert<\/span>.IsFalse(testModel.IsHiding);\n}<\/pre>\nThe code to pass this test should be just adding the following check to the end of MoveModel (as long as Hide is added to the IModel interface).<\/p>\n
foreach <\/span>(IModel <\/span>enemyModel in <\/span>(from <\/span>models in <\/span>_gameManager.Models\nwhere <\/span>models.Player != this<\/span>.Player\nselect <\/span>models))\n{\nenemyModel.Hide();\n}<\/pre>\nBut this doesn\u2019t work \u2013 not only does it not work, but it breaks other tests! Now, Charge_SetsIsChargingFlag, MoveModel_CannotMoveFurtherThanModelsMovement and NewTurn_SetsIsChargingToFalse throw exceptions and this test fails on the penultimate assert that the exception was thrown. I believe the error with this test is that the Mock GameManager I\u2019m using is only returning the enemyModel \u2013 not the testModel. When I added the testModel to the setup, this test at least passes. The other tests all throw exceptions. This is probably due to the fact that the GameManager is not being correctly set up in each case, to return an empty List<IModel> \u2013 as a mock object, it returns null instead and the above code to check for other models fails when passed a null.<\/p>\n
By adding in the required setup line to each of those tests, I get 31 passes again.<\/p>\n
Finally, a model is automatically forced out of hiding if an enemy model is within it\u2019s Initiative range of the hiding model. This one needs to be checked when the model chooses to hide, and also whenever it moves or the enemy model moves. Since all three of these cause the Hide method to be called, that should probably be where it sits. The following tests should cover off those three situations:<\/p>\n
[TestMethod<\/span>]\npublic void <\/span>Hide_CannotHideIfEnemyInInitiativeRange()\n{\nMock<\/span><IGameManager<\/span>> mockGameManager = new <\/span>Mock<\/span><IGameManager<\/span>>();\nMock<\/span><IObjectManager<\/span>> mockObjectManager = new <\/span>Mock<\/span><IObjectManager<\/span>>();\nModel <\/span>testModel = new <\/span>Model<\/span>(1, mockGameManager.Object, mockObjectManager.Object);\nModel <\/span>enemyModel = new <\/span>Model<\/span>(2, mockGameManager.Object, mockObjectManager.Object);\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(0);\ntestModel.Location = new <\/span>LocationPoint<\/span>(0, 0, 0);\nenemyModel.Location = new <\/span>LocationPoint<\/span>(1, 0, 0);\nenemyModel.Initiative = 2;\nmockGameManager.Setup(item => item.Models).Returns(new <\/span>List<\/span><IModel<\/span>>() { enemyModel, testModel });\nbool <\/span>correctExceptionThrown = false<\/span>;\ntry\n<\/span>{\ntestModel.Hide();\n}\ncatch <\/span>(HidingException <\/span>ex)\n{\ncorrectExceptionThrown = true<\/span>;\nAssert<\/span>.AreEqual(enemyModel, ex.EnemyModels[0]);\n}\nAssert<\/span>.IsFalse(testModel.IsHiding);\nAssert<\/span>.IsTrue(correctExceptionThrown);\n}\n[TestMethod<\/span>]\npublic void <\/span>MoveModel_StopHidingIfModelMovesIntoEnemyInitiativeRange()\n{\nMock<\/span><IGameManager<\/span>> mockGameManager = new <\/span>Mock<\/span><IGameManager<\/span>>();\nMock<\/span><IObjectManager<\/span>> mockObjectManager = new <\/span>Mock<\/span><IObjectManager<\/span>>();\nModel <\/span>testModel = new <\/span>Model<\/span>(1, mockGameManager.Object, mockObjectManager.Object);\nModel <\/span>enemyModel = new <\/span>Model<\/span>(2, mockGameManager.Object, mockObjectManager.Object);\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(0);\ntestModel.Location = new <\/span>LocationPoint<\/span>(0, 0, 0);\nenemyModel.Location = new <\/span>LocationPoint<\/span>(5, 0, 0);\nenemyModel.Initiative = 3;\nmockGameManager.Setup(item => item.Models).Returns(new <\/span>List<\/span><IModel<\/span>>() { enemyModel, testModel });\ntestModel.IsHiding = true<\/span>;\ntestModel.Movement = 4;\nbool <\/span>correctExceptionThrown = false<\/span>;\ntry\n<\/span>{\ntestModel.MoveModel(4, 0, 0);\n}\ncatch <\/span>(HidingException <\/span>ex)\n{\ncorrectExceptionThrown = true<\/span>;\nAssert<\/span>.AreEqual(enemyModel, ex.EnemyModels[0]);\n}\nAssert<\/span>.IsFalse(testModel.IsHiding);\nAssert<\/span>.IsTrue(correctExceptionThrown);\n}\n[TestMethod<\/span>]\npublic void <\/span>MoveModel_StopHidingIfEnemyMovesWithinInitiativeRange()\n{\nMock<\/span><IGameManager<\/span>> mockGameManager = new <\/span>Mock<\/span><IGameManager<\/span>>();\nMock<\/span><IObjectManager<\/span>> mockObjectManager = new <\/span>Mock<\/span><IObjectManager<\/span>>();\nModel <\/span>testModel = new <\/span>Model<\/span>(1, mockGameManager.Object, mockObjectManager.Object);\nModel <\/span>enemyModel = new <\/span>Model<\/span>(2, mockGameManager.Object, mockObjectManager.Object);\nmockObjectManager.Setup(item => item.GetLineOfSight(It<\/span>.IsAny<IModel<\/span>>(), It<\/span>.IsAny<IModel<\/span>>())).Returns(0);\ntestModel.Location = new <\/span>LocationPoint<\/span>(5, 0, 0);\nenemyModel.Location = new <\/span>LocationPoint<\/span>(0, 0, 0);\nenemyModel.Initiative = 3;\nmockGameManager.Setup(item => item.Models).Returns(new <\/span>List<\/span><IModel<\/span>>() { enemyModel, testModel });\ntestModel.IsHiding = true<\/span>;\nenemyModel.Movement = 4;\nbool <\/span>correctExceptionThrown = false<\/span>;\ntry\n<\/span>{\nenemyModel.MoveModel(4, 0, 0);\n}\ncatch <\/span>(HidingException <\/span>ex)\n{\ncorrectExceptionThrown = true<\/span>;\nAssert<\/span>.AreEqual(enemyModel, ex.EnemyModels[0]);\n}\nAssert<\/span>.IsFalse(testModel.IsHiding);\nAssert<\/span>.IsTrue(correctExceptionThrown);\n}<\/pre>\nThe passing code sits in Hide, and is very pleasantly simple. Hide becomes very long:<\/p>\n
public void <\/span>Hide()\n{\nif <\/span>(this<\/span>.IsCharging || this<\/span>.IsRunning)\n{\nHidingException <\/span>ex = new <\/span>HidingException<\/span>(\"Cannot hide if charged or ran this turn.\"<\/span>);\nthrow <\/span>ex;\n}\nelse\n<\/span>{\nList<\/span><IModel<\/span>> enemyModels = (from <\/span>models in this<\/span>._gameManager.Models\nwhere <\/span>models.Player != this<\/span>.Player\n&& (this<\/span>._objectManager.GetLineOfSight(models, this<\/span>) > 0.6 || this<\/span>.GetDistanceFrom(models.Location.X, models.Location.Y, models.Location.Z) <= models.Initiative)\nselect <\/span>models).ToList();\nif <\/span>(enemyModels.Count > 0)\n{\nthis<\/span>.IsHiding = false<\/span>;\nHidingException <\/span>ex = new <\/span>HidingException<\/span>(\"Cannot hide in sight or Initiative range of enemy models.\"<\/span>);\nex.EnemyModels = enemyModels;\nthrow <\/span>ex;\n}\nelse\n<\/span>{\nthis<\/span>.IsHiding = true<\/span>;\n}\n}\n}<\/pre>\nBut this breaks several other tests. The reason is that some of the previously written tests are not setting locations for the enemy and test models, and the distance between them (zero) is always equal to or less than the default Initiative value (also zero). Changing the tests to give them a bit of space fixes this problem.<\/p>\n
Since a model can remain hidden for several successive turns, it doesn\u2019t need to reset the IsHiding flag \u2013 Hiding for all hidden models is checked whenever a model is moved, so it will be taken out of hiding when a player wishes or when it is chosen.<\/p>\n
Next time, I move off of page 11, but I\u2019m not sure where to yet…<\/p>\n","protected":false},"excerpt":{"rendered":"
Last time, I got the tests for Charging out of the way, and got through a raft of simple checks for Hiding. This time, a few of the more complicated checks. First off, a model can move around while hiding as long as it remains out of sight. I\u2019m not sure how to be checking … <\/p>\n